Sometime I see AV in destructor TkbmMWCustomTCPIPIndyClientTransport.Destroy;

[VadimMest]

destructor TkbmMWCustomTCPIPIndyClientTransport.Destroy;
begin
     if FSocket<>nil then
     begin
          try
             Disconnect;
          except
          end;
     end;
     FSocket.free;
     FSocket:=nil;
     inherited;
end;

I think it is needed to be changed on

destructor TkbmMWCustomTCPIPIndyClientTransport.Destroy;
begin
     if FSocket<>nil then
     begin
          try
             Disconnect;
          except
          end;
         FSocket.free;
         FSocket:=nil;
     end;
     
     inherited;
end;

• This topic was modified 2 months, 1 week ago by VadimMest.
• This topic was modified 2 months, 1 week ago by VadimMest.

[kimbomadsen]

Logically, yes. The change certainly is not wrong, and I will implement it.
However free is actually supposed to ignore a null self.

It may more indicate that there is a lingering TkbmMWCustomTCPIPIndyClientTransport instance somewhere that may be attempted to be freed by two threads at the same time?

/KBM

[Author]

Posts