Forum Replies Created
-
Since i create the actor on OnLogin event I fixed by cheking autologin:
function TkbmMWAuthorizationManager.InternalLogin(const AActorName:string; const ARoleName:string;
…..
if (ctx.Actor=nil) then
begin
if AAutoCreateActor then
ctx.Actor:=FActors.Add(AActorName,APassPhrase,ARoleName,’Auto created ‘+TkbmMWDateTime.Now.ISO8601String);
if (mwaoAutoLogin in Options) or ((ctx.Actor<>nil) and (not ctx.Actor.Internal)) then // HERE added cheking auto login and fire the event
DoOnLogin(ctx,ctx.FActor,ctx.FRole,ctx.FMessage);If you have something else to suggest let me know
Thank you
Seems their is problem multi monitor environments eg. it doesn’t register monitor 1/primary. the FMonitors[0] value is nil while FMonitors[1] (monitor 2) is mdwn_2.
Changed this line in order to work:
constructor TkbmMWRemoteDesktopClient.Create(AOwner:TComponent);
{$IFDEF FMX}
FID:=TkbmMWRemoteDesktopMonitor.mwrdm_1;
{$ELSE}
// Original: FID:=TkbmMWRemoteDesktopMonitor(Screen.PrimaryMonitor.MonitorNum)FID:=TkbmMWRemoteDesktopMonitor(Screen.PrimaryMonitor.MonitorNum -1);
Testing ….
I found a better solution!
Since our user is already logged in we shouldn’t call DoOnLoginSuccess(ctx); because it’s already called the first time!ctx.TraceMessage:=’Login: Actor already logged in. Actor ‘+ctx.Actor.Name+’, Role=’+ctx.Role.Name+’, At(UTC)=’+DateTimeToStr(Result.LastAuthorized);
//DoOnLoginSuccess(ctx); <– Remove me!Hello Kim,
Checked that and no!The “Trace” of duplicate login:
30/03/2022 09:31| 635450D7EE5A422991BB89EDA6132A6C TRACE: MyUser:33088) Login: Logged in. Actor=MyUser:33088, Role=USER, Location=127.0.0.1:33088 At(UTC)=30/3/2022 6:31:56 πμ
30/03/2022 09:47| 635450D7EE5A422991BB89EDA6132A6C TRACE: MyUser:33088) Logout: LoginToken=635450D7EE5A422991BB89EDA6132A6C
30/03/2022 09:47| 404D861FAB464DBD9D832D1B150AD166 TRACE: MyUser:53421) Login: Logged in. Actor=MyUser:53421, Role=USER, Location=127.0.0.1:53421 At(UTC)=30/3/2022 6:47:43 πμ
30/03/2022 10:06| 404D861FAB464DBD9D832D1B150AD166 TRACE: MyUser:53421) Logout: LoginToken=404D861FAB464DBD9D832D1B150AD166
30/03/2022 10:08| A41785AAF86E4B6CA4B24DA82ACBA9E6 TRACE: MyUser:54034) Login: Logged in. Actor=MyUser:54034, Role=USER, Location=127.0.0.1:54034 At(UTC)=30/3/2022 7:08:02 πμ
30/03/2022 10:08| TRACE: MyUser:54034) Login: Actor already logged in. Actor MyUser:54034, Role=USER, At(UTC)=30/3/2022 7:08:02 πμ // <— HERE!!! It attempts for the 2nd time to login but it’s already logged as you can see above
30/03/2022 10:08| A41785AAF86E4B6CA4B24DA82ACBA9E6 TRACE: MyUser:54034) Logout: LoginToken=A41785AAF86E4B6CA4B24DA82ACBA9E6
30/03/2022 10:08| 7B606826CA9E4F3B84BA89CEDC590971 TRACE: MyUser:54036) Login: Logged in. Actor=MyUser:54036, Role=USER, Location=127.0.0.1:54036 At(UTC)=30/3/2022 7:08:03 πμIf the user is already logged in it will still call “OnLoginSucces” so can you add a flags to “ctx” to know that the user is already logged ?
eg:ctx.AlreadyLogged := True; // <– add this new variable
ctx.Message:=’Already logged in’;
ctx.TraceMessage:=’Login: Actor already logged in. Actor ‘+ctx.Actor.Name+’, Role=’+ctx.Role.Name+’, At(UTC)=’+DateTimeToStr(Result.LastAuthorized);
DoOnLoginSuccess(ctx);Thank you
Hello!
No it doesn’t not! It’s empty and never fills!
As you can see in the code it only assigns the “Token” compared to Logout(const AActor:TkbmMWAuthorizationActor);procedure TkbmMWAuthorizationManager.Logout(const ALoginToken:string);
…
ctx:=TkbmMWAuthorizationContext.Create;
try
ctx.Token:=ALoginToken; //Only this!!!
FLock.BeginWrite;
try
DoOnLogout(ctx);
….procedure TkbmMWAuthorizationManager.Logout(const AActor:TkbmMWAuthorizationActor);
….
ctx.Token:=l.Token;
ctx.ActorName:=AActor.Name;
ctx.Role:=l.Role;
ctx.Login:=l;
DoOnLogout(ctx);
….The ctx information is needed for login2 and logout2 and trace2 of AuthorizationManager!
So in case that GarbageCollection Logout out the user i use the CTX to retrieve his informations. (eg the Actorname).Thank you
Dear Kim,
I can totally understand and accept since i’m a single developer too but i do not want to loose customers because i do not respond.
In my life i learnt with the soft and the hard way that “Support” is the 1st thing to make customers happy and keeping them. If they can’t reach me they look solutions and/or alternative elsewhere and they did. (I’m not the only guy developing or fixing computers in my town)
Do not get me wrong, the product is awesome by itself but it had and has some critical bugs which it needed to be fixed in order a project to proceed. Speaking for my self i spend a lot of hours and sometime days for bug caused by kbmMW and not from my project (and you know how difficult is to trace a bug in a multi-threaded application) and on the other half i was waiting weeks for a response.
I do not compare you with DevExpress which they respond the same day but a lot of Open Source projects on Github respond way faster in their bugreports.
Since i have invested in kbmMW i do not want to leave and go into another framework because i know you a very awesome developer and supporter of Delphi ecosystem but please find a solution for quick support as other project have in here. (I understand e-mail is a priority but i do not have $156 since my project are for my own use and not commercial so far)
I will renew my subscription in the coming couple months because i believe that you’ll find a solution to this!
Thank you 🙂
